[FIX] Order 2

src/Gargantext/Core/Viz/Graph/Index.hs

@@ -24,21 +24,16 @@ TODO:
 module Gargantext.Core.Viz.Graph.Index
   where
 
-import qualified Data.Array.Accelerate as A
-import qualified Data.Array.Accelerate.Interpreter as A
 import Data.Array.Accelerate (Matrix, Elt, Shape, (:.)(..), Z(..))
-
+import Data.Map (Map)
 import Data.Maybe (fromMaybe, catMaybes)
-
 import Data.Set (Set)
-import qualified Data.Set as S
-
-import Data.Map (Map)
-import qualified Data.Map.Strict    as M
-
--- import Data.Vector (Vector)
-
 import Gargantext.Prelude
+import qualified Data.Array.Accelerate as A
+import qualified Data.Array.Accelerate.Interpreter as A
+import qualified Data.Map.Strict       as M
+import qualified Data.Set              as S
+import qualified Data.List             as L
 
 type Index    = Int
 
@@ -98,13 +93,15 @@ indexConversion index ms = M.fromList
                                                       <*> Just c)
                                 )
                          $ M.toList ms
----------------------------------------------------------------------------------
 
--------------------------------------------------------------------------------
+
+------------------------------------------------------------------------
+------------------------------------------------------------------------
+
 --fromIndex' :: Ord t => Vector t -> Map (Index, Index) a -> Map (t,t) a
 --fromIndex' vi ns = undefined
 
--- TODO: returing a Vector should be faster than a Map
+-- TODO: returning a Vector should be faster than a Map
 -- createIndices' :: Ord t => Map (t, t) b -> (Map t Index, Vector t)
 -- createIndices' = undefined
 
@@ -123,4 +120,17 @@ createIndices = set2indices . map2set
         toIndex'   = zip xs [0..]
         xs         = S.toList s
 
+------------------------------------------------------------------------
+------------------------------------------------------------------------
+
+testIndices :: Bool
+testIndices = myMap == ( M.filter (>0) myMap')
+  where
+    xy      = L.zip ([0..30]:: [Int]) ([0..30]:: [Int])
+    myMap   = M.fromList $ L.zip xy ([1..]:: [Int])
+    (ti,it) = createIndices myMap
+    matrix  = mat2map $ map2mat Square 0 (M.size ti) $ toIndex ti myMap
+    myMap'  = fromIndex it matrix
+
+
 

src/Gargantext/Core/Viz/Graph/Tools.hs

@@ -14,25 +14,22 @@ Portability : POSIX
 module Gargantext.Core.Viz.Graph.Tools
   where
 
--- import Data.Graph.Clustering.Louvain (hLouvain, {-iLouvainMap-})
 import Data.HashMap.Strict (HashMap)
 import Data.Map (Map)
-import Data.Text (Text)
--- import Debug.Trace (trace)
+import Data.Maybe (fromMaybe)
 import GHC.Float (sin, cos)
 import Gargantext.API.Ngrams.Types (NgramsTerm(..))
-import Gargantext.Core.Methods.Distances.Conditional (conditional)
 import Gargantext.Core.Methods.Distances (Distance(..), measure)
+import Gargantext.Core.Methods.Distances.Conditional (conditional)
 import Gargantext.Core.Methods.Graph.BAC.Proxemy (confluence)
 import Gargantext.Core.Statistics
 import Gargantext.Core.Viz.Graph
-import Gargantext.Core.Viz.Graph.Utils (edgesFilter)
 import Gargantext.Core.Viz.Graph.Bridgeness (bridgeness, Partitions, ToComId(..))
 import Gargantext.Core.Viz.Graph.Index (createIndices, toIndex, map2mat, mat2map, Index, MatrixShape(..))
 import Gargantext.Core.Viz.Graph.Tools.IGraph (mkGraphUfromEdges, spinglass)
 import Gargantext.Core.Viz.Graph.Types (ClusterNode)
+import Gargantext.Core.Viz.Graph.Utils (edgesFilter)
 import Gargantext.Prelude
--- import qualified Graph.BAC.ProxemyOptim as BAC
 import IGraph.Random -- (Gen(..))
 import qualified Data.HashMap.Strict      as HashMap
 import qualified Data.List                as List
@@ -95,12 +92,6 @@ cooc2graphWith' doPartitions distance threshold myCooc = do
   let
     (distanceMap, diag, ti) = doDistanceMap distance threshold myCooc
 
-    nodesApprox :: Int
-    nodesApprox = n'
-      where
-        (as, bs) = List.unzip $ Map.keys distanceMap
-        n' = Set.size $ Set.fromList $ as <> bs
-
 {- -- Debug
   saveAsFileDebug "debug/distanceMap" distanceMap
   printDebug "similarities" similarities
@@ -111,12 +102,15 @@ cooc2graphWith' doPartitions distance threshold myCooc = do
       else panic "Text.Flow: DistanceMap is empty"
 
   let
+    nodesApprox :: Int
+    nodesApprox = n'
+      where
+        (as, bs) = List.unzip $ Map.keys distanceMap
+        n' = Set.size $ Set.fromList $ as <> bs
     bridgeness' = bridgeness (fromIntegral nodesApprox) partitions distanceMap
-
     confluence' = confluence (Map.keys bridgeness') 3 True False
 
-  pure $ data2graph (Map.toList $ Map.mapKeys unNgramsTerm ti)
-                    diag bridgeness' confluence' partitions
+  pure $ data2graph ti diag bridgeness' confluence' partitions
 
 
 doDistanceMap :: Distance
@@ -148,87 +142,88 @@ doDistanceMap Distributional threshold myCooc = (distanceMap, toIndex ti diag, t
                  $ map2mat Square 0 tiSize
                  $ toIndex ti theMatrix
 
-    links = round (let n :: Double = fromIntegral tiSize in n * log n)
+    links = round (let n :: Double = fromIntegral tiSize in n * (log n)^(2::Int))
 
     distanceMap = Map.fromList
                 $ List.take links
+                $ List.reverse
                 $ List.sortOn snd
                 $ Map.toList
                 $ edgesFilter
                 $ Map.filter (> threshold)
                 $ mat2map similarities
 
-doDistanceMap Conditional _threshold myCooc = (distanceMap, toIndex ti myCooc', ti)
+doDistanceMap Conditional threshold myCooc = (distanceMap, toIndex ti myCooc', ti)
   where
     myCooc' = Map.fromList $ HashMap.toList myCooc
     (ti, _it) = createIndices myCooc'
-    -- tiSize  = Map.size ti
+    tiSize  = Map.size ti
 
-    -- links = round (let n :: Double = fromIntegral tiSize in n * log n)
+    links = round (let n :: Double = fromIntegral tiSize in n * log n)
 
     distanceMap = toIndex ti
                 $ Map.fromList
-                --  List.take links
-                --  List.sortOn snd
+                $ List.take links
+                $ List.sortOn snd
                 $ HashMap.toList
-                --  HashMap.filter (> threshold)
+                $ HashMap.filter (> threshold)
                 $ conditional myCooc
 
-
-
 ----------------------------------------------------------
 -- | From data to Graph
 
-type Occurrences  = Map (Int,  Int) Int
+type Occurrences      = Int
 
 data2graph :: ToComId a 
-           => [(Text, Int)]
-           -> Occurrences
+           => Map NgramsTerm Int
+           -> Map (Int, Int) Occurrences
            -> Map (Int, Int) Double
            -> Map (Int, Int) Double
            -> [a]
            -> Graph
-data2graph labels occurences bridge conf partitions = Graph { _graph_nodes = nodes
+data2graph labels' occurences bridge conf partitions = Graph { _graph_nodes = nodes
                                                              , _graph_edges = edges
                                                              , _graph_metadata = Nothing
                                                              }
   where
 
-    community_id_by_node_id = Map.fromList
-                            $ map nodeId2comId partitions
-
     nodes = map (setCoord ForceAtlas labels bridge)
           [ (n, Node { node_size    = maybe 0 identity (Map.lookup (n,n) occurences)
                      , node_type    = Terms -- or Unknown
                      , node_id      = cs (show n)
-                     , node_label   = l
+                     , node_label   = unNgramsTerm l
                      , node_x_coord = 0
                      , node_y_coord = 0
-                     , node_attributes =
-                       Attributes { clust_default = maybe 0 identity
-                                    (Map.lookup n community_id_by_node_id) }
+                     , node_attributes = Attributes { clust_default = fromMaybe 0
+                                                       (Map.lookup n community_id_by_node_id)
+                                                    }
                      , node_children = [] }
                )
             | (l, n) <- labels
-            , Set.member n $ Set.fromList
-                           $ List.concat
-                           $ map (\((s,t),d) -> if d > 0 && s /=t then [s,t] else [])
-                           $ Map.toList bridge
+            , Set.member n nodesWithScores
             ]
 
     edges = [ Edge { edge_source = cs (show s)
                        , edge_target = cs (show t)
                        , edge_weight = weight
                        , edge_confluence = maybe 0 identity $ Map.lookup (s,t) conf
-                   -- , edge_confluence = maybe (panic "E: data2graph edges") identity $ Map.lookup (s,t) conf
                        , edge_id     = cs (show i)
                    }
-            | (i, ((s,t), weight)) <- zip ([0..]::[Integer] )
-                                     (Map.toList bridge)
+            | (i, ((s,t), weight)) <- zip ([0..]::[Integer] ) $ Map.toList bridge
             , s /= t
             , weight > 0
             ]
 
+    community_id_by_node_id = Map.fromList
+                            $ map nodeId2comId partitions
+
+    labels = Map.toList labels'
+
+    nodesWithScores = Set.fromList
+                     $ List.concat
+                     $ map (\((s,t),d) -> if d > 0 && s/=t then [s,t] else [])
+                     $ Map.toList bridge
+
 
 ------------------------------------------------------------------------