Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
gargantext
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
humanities
gargantext
Commits
835265dd
Commit
835265dd
authored
Sep 16, 2016
by
Romain Loth
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comments: clarify importance of _query_nodes() for user permissions verification
parent
19154fcf
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
2 deletions
+9
-2
nodes.py
gargantext/views/api/nodes.py
+9
-2
No files found.
gargantext/views/api/nodes.py
View file @
835265dd
...
...
@@ -22,7 +22,13 @@ _node_available_types = NODETYPES
def
_query_nodes
(
request
,
node_id
=
None
):
if
request
.
user
.
id
is
None
:
raise
TypeError
(
"This API request must come from an authenticated user."
)
else
:
# we query among the nodes that belong to this user
user
=
cache
.
User
[
request
.
user
.
id
]
# parameters validation
parameters
=
get_parameters
(
request
)
parameters
=
validate
(
parameters
,
{
'type'
:
dict
,
'items'
:
{
...
...
@@ -210,7 +216,7 @@ class NodeListHaving(APIView):
class
NodeResource
(
APIView
):
#
TODO either real authentification test or remove check on user.id
#
contains a check on user.id (within _query_nodes)
def
get
(
self
,
request
,
node_id
):
parameters
,
query
,
count
=
_query_nodes
(
request
,
node_id
)
if
not
len
(
query
):
...
...
@@ -220,6 +226,7 @@ class NodeResource(APIView):
field
:
getattr
(
node
,
field
)
for
field
in
parameters
[
'fields'
]
})
# contains a check on user.id (within _query_nodes)
def
delete
(
self
,
request
,
node_id
):
parameters
,
query
,
count
=
_query_nodes
(
request
,
node_id
)
if
not
len
(
query
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment