Commit 2fc18ac6 authored by Romain Loth's avatar Romain Loth

on the way, better 'readd edge' logic

parent bf66d4d8
...@@ -1059,54 +1059,41 @@ function EdgeWeightFilter(sliderDivID , reltypestr , criteria) { ...@@ -1059,54 +1059,41 @@ function EdgeWeightFilter(sliderDivID , reltypestr , criteria) {
if(i>=low && i<=high) { if(i>=low && i<=high) {
if(addflag) { if(addflag) {
// console.log("adding "+ids.join()) // console.log("adding "+ids.join())
for(var i in eids) { for(var i in eids) {
let eid = eids[i] let eid = eids[i]
if (TW.Edges[eid]) // we need to distinguish between
TW.Edges[eid].lock = false; // - absent edges
else // => keep them absent because of local
console.warn("skipped missing eid", eid) // - edges with absent nodes
// => effect of a node slider => make them appear
// local level case let e = TW.partialGraph.graph.edges(eid)
// stepToIdsArr is full of edges that don't really exist at this point if (e) {
// we need to distinguish between absent edges => keep them absent because of local let nidkeys = eid.split(';')
// and edges with hidden nodes => effect of a node slider => make them appear
if (! present.level) { if (nidkeys.length != 2) {
console.error("invalid edge id:" + eid)
// NB we assume the sigma convention eid = "nid1;nid2"
let nidkeys = eid.split(';')
if (nidkeys.length != 2) {
console.error("invalid edge id:" + eid)
}
else {
let sid = nidkeys[0]
let tid = nidkeys[1]
// if nodes not removed by local view
if ( TW.partialGraph.graph.nodes(sid)
&& TW.partialGraph.graph.nodes(tid)) {
if(TW.partialGraph.graph.nodes(sid).hidden) unHide(sid)
if(TW.partialGraph.graph.nodes(tid).hidden) unHide(tid)
if (! TW.partialGraph.graph.edges(eid)) {
add1Elem(eid)
}
TW.partialGraph.graph.edges(eid).hidden = false
TW.Edges[eid].lock = false;
}
}
} }
// in any case we show the edge else {
// global level case let sid = nidkeys[0]
if (! TW.partialGraph.graph.edges(eid)) { let tid = nidkeys[1]
// legacy fallback shouldn't be necessary
add1Elem(eid) let src = TW.partialGraph.graph.nodes(sid)
let tgt = TW.partialGraph.graph.nodes(tid)
// if nothing is absent (nodes not
// removed by changetype or local view)
if (src && tgt) {
// unhide in case nodeslider hid them
src.hidden = false
tgt.hidden = false
e.hidden = false
}
} }
TW.partialGraph.graph.edges(eid).hidden = false }
TW.Edges[eid].lock = false;
} }
} }
} else { } else {
if(delflag) { if(delflag) {
for(var i in eids) { for(var i in eids) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment