Commit ba7cd9c8 authored by Sumit Sahrawat's avatar Sumit Sahrawat Committed by Sumit Sahrawat

Fix #665: Incomplete KernelInfoReply from EasyKernel.replyTo

parent c783897d
...@@ -77,6 +77,10 @@ data KernelConfig m output result = ...@@ -77,6 +77,10 @@ data KernelConfig m output result =
-- should be handled by defining an appropriate error constructor in your result type. -- should be handled by defining an appropriate error constructor in your result type.
, run :: T.Text -> IO () -> (output -> IO ()) -> m (result, ExecuteReplyStatus, String) , run :: T.Text -> IO () -> (output -> IO ()) -> m (result, ExecuteReplyStatus, String)
, debug :: Bool -- ^ Whether to print extra debugging information to , debug :: Bool -- ^ Whether to print extra debugging information to
-- | A One-line description of the kernel
, kernelBanner :: String
-- | The version of the messaging specification used by the kernel
, kernelProtocolVersion :: String
} }
-- Install the kernelspec, using the `writeKernelspec` field of the kernel configuration. -- Install the kernelspec, using the `writeKernelspec` field of the kernel configuration.
...@@ -162,7 +166,10 @@ replyTo config _ _ KernelInfoRequest{} replyHeader = ...@@ -162,7 +166,10 @@ replyTo config _ _ KernelInfoRequest{} replyHeader =
, languageInfo = kernelLanguageInfo config , languageInfo = kernelLanguageInfo config
, implementation = "ipython-kernel.EasyKernel" , implementation = "ipython-kernel.EasyKernel"
, implementationVersion = "0.0" , implementationVersion = "0.0"
, banner = kernelBanner config
, protocolVersion = kernelProtocolVersion config
} }
replyTo config _ interface ShutdownRequest { restartPending = pending } replyHeader = do replyTo config _ interface ShutdownRequest { restartPending = pending } replyHeader = do
liftIO $ writeChan (shellReplyChannel interface) $ ShutdownReply replyHeader pending liftIO $ writeChan (shellReplyChannel interface) $ ShutdownReply replyHeader pending
liftIO exitSuccess liftIO exitSuccess
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment