Squashed commit of the following:

commit 28e2927e
Author: Grégoire Locqueville <gregoire.locqueville@cnrs.fr>
Date:   Mon Dec 2 17:06:29 2024 +0100

    Deal with error with a proper error

    ... instead of returning a `Maybe` to the frontend

commit 54675ae8
Author: Grégoire Locqueville <gregoire.locqueville@cnrs.fr>
Date:   Mon Dec 2 16:27:03 2024 +0100

    Return Maybe (node ID) upon creating a subcorpus

src/Gargantext/API/Node/Corpus/Subcorpus.hs

 module Gargantext.API.Node.Corpus.Subcorpus where
 
+import Data.Validity (Validation(..), ValidationChain(..))
 import Gargantext.Prelude
-
-import Gargantext.API.Errors.Types (BackendInternalError)
+import Gargantext.API.Errors.Types (BackendInternalError(..))
 import Gargantext.API.Routes.Named.Corpus (MakeSubcorpusAPI(..), SubcorpusParams(..))
 import Gargantext.Core.NodeStory.Types (HasNodeStoryEnv)
 import Gargantext.Core.NLP (HasNLPServer)
@@ -21,12 +21,14 @@ makeSubcorpus :: ( HasNodeStoryEnv env
   => UserId
   -> MakeSubcorpusAPI (AsServerT m)
 makeSubcorpus user = MakeSubcorpusAPI $ \corpusId params -> do
-  case parseQuery (RawQuery $ _subcorpusParams_query params) of
-    Left _  -> return False
-    Right q -> do
-      _ <- makeSubcorpusFromQuery
+  let queryText = _subcorpusParams_query params
+  case parseQuery (RawQuery queryText) of
+    Left msg -> throwError $ InternalValidationError $ Validation [Violated $
+                  "Failed to parse the query " <> show queryText <> ": " <> msg]
+    Right q  -> do
+      subcorpusId <- makeSubcorpusFromQuery
              (UserDBId user)
              corpusId
              q
              (_subcorpusParams_reuseParentList params)
-      return True
+      return subcorpusId

src/Gargantext/API/Routes/Named/Corpus.hs

@@ -30,7 +30,7 @@ import Gargantext.API.Node.Types (NewWithForm, WithQuery)
 import Gargantext.API.Worker (WorkerAPI)
 import Gargantext.Core.Text.Ngrams (NgramsType(..))
 import Gargantext.Core.Utils.Prefix (unPrefix, unPrefixSwagger)
-import Gargantext.Database.Admin.Types.Node (CorpusId, ListId)
+import Gargantext.Database.Admin.Types.Node (CorpusId, ListId, NodeId)
 import Gargantext.Prelude (Bool)
 import Servant
 
@@ -67,7 +67,7 @@ newtype MakeSubcorpusAPI mode = MakeSubcorpusAPI
                      :> Capture "corpus_id" CorpusId
                      :> "subcorpus"
                      :> ReqBody '[JSON] SubcorpusParams
-                     :> Post '[JSON] Bool -- was request successful
+                     :> Post '[JSON] NodeId -- new subcorpus ID
   } deriving Generic
 
 data SubcorpusParams = SubcorpusParams

src/Gargantext/API/Server/Named/Private.hs

@@ -61,7 +61,7 @@ serverPrivateGargAPI' authenticatedUser@(AuthenticatedUser userNodeId userId)
        , membersAPI        = members
        , addWithFormAPI    = addCorpusWithForm (RootId userNodeId)
        , addWithQueryEp    = addCorpusWithQuery (RootId userNodeId)
-       , makeSubcorpusAPI      = Subcorpus.makeSubcorpus userId
+       , makeSubcorpusAPI  = Subcorpus.makeSubcorpus userId
        , listGetAPI        = List.getAPI
        , listJsonAPI       = List.jsonAPI
        , listTsvAPI        = List.tsvAPI