[BUG] Flow continuation <> bugs persists (cont should be empty)

src/Gargantext/Core/Text/List/Group/WithScores.hs

@@ -70,18 +70,18 @@ fromScores'' f' (t, fs) = ( maybeParent
 toGroupedTree :: Map (Maybe Parent) (Map Text (GroupedTreeScores (Set NodeId)))
               -> Map Parent (GroupedTreeScores (Set NodeId))
 toGroupedTree m = case Map.lookup Nothing m of
-  Nothing  -> Map.empty
+  Nothing  -> mempty
   Just  m' -> toGroupedTree' m m'
 
 toGroupedTree' :: Map (Maybe Parent) (Map Text (GroupedTreeScores (Set NodeId)))
                -> (Map Text (GroupedTreeScores (Set NodeId)))
                -> Map Parent (GroupedTreeScores (Set NodeId))
 toGroupedTree' m notEmpty
-  | notEmpty == Map.empty = Map.empty
+  | notEmpty == mempty = mempty
   | otherwise = Map.mapWithKey (addGroup m) notEmpty
     where
       addGroup m' k v = over gts'_children ( (toGroupedTree' m')
-                                           . (Map.union ( fromMaybe Map.empty
+                                           . (Map.union ( fromMaybe mempty
                                                         $ Map.lookup (Just k) m'
                                                         )
                                              )
@@ -136,21 +136,21 @@ addIfNotExist :: Map Text FlowListScores
               -> Map Text (Set NodeId)
               -> Map Text (GroupedTextScores (Set NodeId))
 addIfNotExist mapSocialScores mapScores =
-  foldl' (addIfNotExist' mapSocialScores) Map.empty $ Map.toList mapScores
+  foldl' (addIfNotExist' mapSocialScores) mempty $ Map.toList mapScores
     where
       addIfNotExist' mss m (t,ns) =
         case Map.lookup t mss of
           Nothing -> Map.alter (add ns) t m
           _       -> m
 
-      add ns' Nothing = Just $ GroupedTextScores Nothing ns' Set.empty
+      add ns' Nothing = Just $ GroupedTextScores Nothing ns' mempty
       add _ _         = Nothing -- should not be present
 
 ------------------------------------------------------------------------
 ------------------------------------------------------------------------
 fromGroupedScores :: Map Parent GroupedWithListScores
                   -> Map Parent (GroupedTextScores (Set NodeId))
-fromGroupedScores = Map.map (\(GroupedWithListScores l c) -> GroupedTextScores l Set.empty c)
+fromGroupedScores = Map.map (\(GroupedWithListScores l c) -> GroupedTextScores l mempty c)
 
 ------------------------------------------------------------------------
 fromListScores :: Map Text FlowListScores -> Map Parent GroupedWithListScores

src/Gargantext/Core/Text/List/Group/WithStem.hs

@@ -59,7 +59,7 @@ groupWithStem' g flc
     | g == GroupIdentity = FlowCont ( (<>) 
                                       (view flc_scores flc)
                                       (view flc_cont   flc)
-                                    ) Map.empty
+                                    ) mempty
     | otherwise = mergeWith (groupWith g) flc
 
 -- | MergeWith : with stem, we always have an answer
@@ -67,7 +67,7 @@ groupWithStem' g flc
 mergeWith :: (Text -> Text)
           -> FlowCont Text (GroupedTreeScores (Set NodeId))
           -> FlowCont Text (GroupedTreeScores (Set NodeId))
-mergeWith fun flc = FlowCont scores Map.empty
+mergeWith fun flc = FlowCont scores mempty
   where
 
     scores :: Map Text (GroupedTreeScores (Set NodeId))

src/Gargantext/Core/Text/List/Social/Prelude.hs

@@ -49,7 +49,9 @@ instance (Eq a, Ord a, Eq b) => Semigroup (FlowCont a b) where
       = FlowCont m s
         where
           m = Map.union        m1 m2
-          s = Map.intersection s1 s2
+          s | s1 == mempty = s2
+            | s2 == mempty = s1
+            | otherwise = Map.intersection s1 s2
 
 makeLenses ''FlowCont
 

src/Gargantext/Core/Text/List/Social/Scores.hs

@@ -72,7 +72,7 @@ addList :: ListType
         -> Maybe FlowListScores
         -> Maybe FlowListScores
 addList l Nothing =
-  Just $ set fls_listType (addListScore l Map.empty) mempty
+  Just $ set fls_listType (addListScore l mempty) mempty
 
 addList l (Just fls) =
   Just $ over fls_listType (addListScore l) fls
@@ -101,9 +101,9 @@ addParent :: KeepAllParents -> NgramsRepoElement -> Set Text
           -> Maybe FlowListScores
 
 addParent k nre ss Nothing  =
-  Just $ FlowListScores Map.empty mapParent
+  Just $ FlowListScores mempty mapParent
     where
-      mapParent = addParentScore k (view nre_parent nre) ss Map.empty
+      mapParent = addParentScore k (view nre_parent nre) ss mempty
 
 addParent k nre ss (Just fls{-(FlowListScores mapList mapParent)-}) =
   Just $ over fls_parents (addParentScore k (view nre_parent nre) ss) fls