Fix unsound DefaultFromField (Maybe NodeNodeCategory) instance

src/Gargantext/Database/Query/Table/Node/Update.hs

@@ -73,7 +73,8 @@ update loggedInUserId (Move sourceId targetId) = do
           -> -- both are not read-only, normal move
              move_db_update sourceId targetId
         (False, True)
-          -> (:[]) <$> publish_node (SourceId sourceId) (TargetId targetId) NPP_publish_no_edits_allowed
+          -> do void $ publish_node (SourceId sourceId) (TargetId targetId) NPP_publish_no_edits_allowed
+                move_db_update sourceId targetId
         (True, False)
           -> -- the source is read only. If we are the owner we allow unpublishing.
              -- FIXME(adn) is this check enough?

src/Gargantext/Database/Schema/NodeNode.hs

@@ -76,7 +76,7 @@ instance HasDBid NodeNodeCategory where
     NNC_publish <$> lookupDBid x
 
 instance DefaultFromField SqlInt4 (Maybe NodeNodeCategory) where
-    defaultFromField = lookupDBid <$> fromPGSFromField
+    defaultFromField = (lookupDBid =<<) <$> fromPGSFromField
 
 type NodeNode = NodeNodePoly NodeId NodeId (Maybe Double) (Maybe NodeNodeCategory)