- 21 Jul, 2025 2 commits
-
-
Alfredo Di Napoli authored
This commit generalises the API we have seen for Ngrams and NgramsElement to Ngrams and NgramsRepoElement, making it suitable for the NodeStory manipulations. Furthermore, we use zippers to efficiently traverse forests. This paves the way for a more disciplined way of handling forests of ngrams.
-
Alfredo Di Napoli authored
-
- 14 Jul, 2025 9 commits
-
-
Alfredo Di Napoli authored
It turns out that we don't need to call `pruneForest` inside `searchtableNgrams`. After all, we are just displaying information that should be correct in the database from the get-go, so why we would need any of that? It turns out that the fix for #313 to support duplicated ngrams during importing broke hierarchical grouping. I have just temporarily commented out the code and I need to find a fix, better also writing a test to ensure that grouping will still work in the future.
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This function allows us to keep only the roots, and discard the redundant children after building a 'Forest'.
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
I think we can use the NgramsTree and NgramsForest types to our advantage for the 'searchTableNgrams' & co, so I have revamped that module to put it to good use.
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This commit changes the implementation of filterNgramsNodes to not filter too aggressively nodes that are present in a path. This causes a test failure that needs to be investigated.
-
Alfredo Di Napoli authored
-
- 09 Jul, 2025 1 commit
-
-
Fabien Maniere authored
[openalex] make search act similar to the one on openalex web See merge request !425
-
- 08 Jul, 2025 3 commits
-
-
Przemyslaw Kaminski authored
Port all the tasty specs to hspec See merge request !423
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
See #490
-
- 02 Jul, 2025 1 commit
-
-
Fabien Maniere authored
Resolve "Error uploading zip file on dev" See merge request !417
-
- 30 Jun, 2025 8 commits
-
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
Fix bug in DB transaction rollbacks in the presence of domain-specific errors Closes #480 See merge request !420
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
- 26 Jun, 2025 1 commit
-
-
Przemyslaw Kaminski authored
-
- 23 Jun, 2025 5 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This commit fixes the bug with DbTx rollbacks and domain-specific errors. What we do now is throwing an exception during the evaluation of `DbFail`, to later catch it _after_ `withTransactionM` has performed a clean rollback, and only at that point we call `throwError`. This also means that we need to catch `DbTx` errors via the `MonadError` interface, not via the exception-handling interface, to get proper rollback behavior.
-
Alfredo Di Napoli authored
errorWith has a `HasNodeError` constraint but the name was misleading.
-
Alfredo Di Napoli authored
This means, of course, that now rollback tests are failing, but that's fine, we can then fix things properly in the DbTx code.
-
Alfredo Di Napoli authored
-
- 20 Jun, 2025 2 commits
-
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
- 19 Jun, 2025 1 commit
-
-
Alfredo Di Napoli authored
Have `extractNgramsFromDocument` catch the right exception in case extraction fails Closes #481 See merge request !419
-
- 16 Jun, 2025 7 commits
-
-
Przemyslaw Kaminski authored
[graphql] get contexts for ngrams fix See merge request !416
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
Resolve "API refactorings" See merge request !412
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-