Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 166
    • Issues 166
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 11
    • Merge Requests 11
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Issues
  • #275

Closed
Open
Opened Oct 06, 2023 by Przemyslaw Kaminski@cgenie
  • Report abuse
  • New issue
Report abuse New issue

`dateSplit` function is wrong

We have the dateSplit function

https://gitlab.iscpif.fr/gargantext/haskell-gargantext/blob/5dcd18405125a3a495d4e9556691e96c0f26314d/src/Gargantext/Core/Text/Corpus/Parsers/Date.hs#L51

It is in the IO monad only because, upon failure, we use getCurrentTime underneath. However, the function itself can return a Nothing.

My proposition is to remove the IO monad altogether: if parsing fails, just return a Nothing.

It is not difficult to fix, however I create an issue because I don't want to break things in the 007 release.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext#275