Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 175
    • Issues 175
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Issues
  • #346

Closed
Open
Opened May 27, 2024 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
  • New issue
Report abuse New issue

`nodeErrorToFrontendError` contains an `undefined`

Historically there was an oversight (my bad, alas) where the nodeErrorToFrontendError didn't handle the case for NoUserFound and instead of emitting a FrontendError it's simply exploding with an undefined.

The reason why that was left there was that I wasn't sure about how to represent the error to the frontend (without leaking information etc) and I think I have simply forgot, and things got merged with that.

We should remove that and also switch to use Gargantext.Prelude in that module, so that uses of undefined would be marked as warnings at compilation time; if that was the case, I'd have noticed (hopefully 😉 ).

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext#346