Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 179
    • Issues 179
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Issues
  • #431

Closed
Open
Opened Dec 09, 2024 by Grégoire Locqueville@glocqueville
  • Report abuse
  • New issue
Report abuse New issue

Remove Dead Code

I'm making a new issue about this, since #387 (closed) was automatically closed when the corresponding branch --- which removed some, but not all dead code --- was merged; issue #387 (closed) was a bit old anyway. Now that I am more familiar with the project and have a bit of time to deal with this, I feel like this is a good time to get my hands a little more dirty with it.

Ideally, I'd like for weeder to not turn up any symbols. This means going through each definition spotted by weeder (of which there are a lot!), and for each, determine whether:

  • It should be kept for some reason (e.g. it is useful in the REPL, as runCmdReplEasy is). If so, whitelist it by adding it to the weeder.toml file with a comment indicating why it is whitelisted for future developers to make an informed decision should they decide to go through a similar process.
  • Or it is obsolete. If so, delete it.

Once that's done, weeder could even potentially be added to the CI pipeline?

Tangentially, this might also be an opportunity to make all exports explicit, and all imports either explicit or qualified, which is generally good practice.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext#431