Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 166
    • Issues 166
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !162

Merged
Opened Jun 02, 2023 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Apply ListType transformation to the children of a given Ngram ( #217 )

@anoe I think I have successfully managed to reproduce #217 (closed) via a minimal test case, that this patch includes. By running the test, we could see the problem: as you and @cgenie guessed, it seems like the patch is correctly turning the root into a StopTerm, but not the children:

expected: Just (
    fromList [
      (
        NgramsTerm {unNgramsTerm = "advantage"}
      ,NgramsRepoElement {
          _nre_size = 1
        , _nre_list = StopTerm
        , _nre_root = Just (NgramsTerm {unNgramsTerm = "advantages"})
        , _nre_parent = Just (NgramsTerm {unNgramsTerm = "advantages"})
        , _nre_children = MSet (fromList [])
      }
    )
    ,(
        NgramsTerm {unNgramsTerm = "advantages"}
      ,NgramsRepoElement {
          _nre_size = 1
        , _nre_list = StopTerm
        , _nre_root = Nothing
        , _nre_parent = Nothing
        , _nre_children = MSet (fromList [(NgramsTerm {unNgramsTerm = "advantage"},())])
      }
    )
  ]
)
but got:  Just (
    fromList [
      (
        NgramsTerm {unNgramsTerm = "advantage"}
      ,NgramsRepoElement {
          _nre_size = 1
        , _nre_list = MapTerm
        , _nre_root = Just (NgramsTerm {unNgramsTerm = "advantages"})
        , _nre_parent = Just (NgramsTerm {unNgramsTerm = "advantages"})
        , _nre_children = MSet (fromList [])
      }
    )
    ,(
        NgramsTerm {unNgramsTerm = "advantages"}
      ,NgramsRepoElement {
          _nre_size = 1
        , _nre_list = StopTerm
        , _nre_root = Nothing
        , _nre_parent = Nothing
        , _nre_children = MSet (fromList [(NgramsTerm {unNgramsTerm = "advantage"},())])
      }
    )
  ]
)

I'm out of time for this week and I'll investigate this further next week, but I think that as far as this comment goes, the Applicable is certainly not problematic here, as my test checks that we can apply this patch (and that part works), but yet the patch is applied incorrectly. I suspect we might need to take a look at the instance Action we defined and carefully analyse in which order they are called.

This begs the question about when this regression happened -- IIUC, this used to work before, right?

Edited Jun 05, 2023 by Alfredo Di Napoli

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-217 origin/adinapoli/issue-217

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-217

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 9
  • Commits 4
  • Pipelines 3
  • Changes 4
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!162

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.