Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 161
    • Issues 161
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !177

Merged
Opened 1 year ago by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Store the `Lang` in a HyperdataCorpus, pass it in strategic places when it matters

Hopefully fixes #250 (closed).

@anoe , I'm out of time for this week and I've kinda rushed this ticket, but I wanted to give you something tangible before the end of the day. Probably you might have to do some extra tweaks, but hopefully it should not be too far off.

@cgenie It was my first time querying and updating the DB, so I'm not sure if I've done this right. Could you quickly review the addLanguageToCorpus function provided as part of this MR and tell me if I'm doing anything super stupid? Also, I'm not sure what is the story for the DB migration -- perhaps we should have a Maybe Lang in the HyperdataCorpus to treat this as an optional field in the internal JSON, avoiding the need for migrations? Any input would be appreciated.

This is untested.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-250 origin/adinapoli/issue-250

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-250

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge adinapoli/issue-250 into dev
  • Email patches
  • Plain diff
Pipeline #4382 passed with warnings for 6219c04b on !177 with adinapoli/issue-250

    Merged by delanoe 1 year ago

    The changes were merged into dev with 6219c04b

    Closed #250 (closed)

    • Discussion 1
    • Commits 5
    • Pipelines 2
    • Changes 9
    • Loading...
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    participants
    Reference: gargantext/haskell-gargantext!177

    Revert this commit

    This will create a new commit in order to revert the existing changes.

    Switch branch
    Cancel
    A new branch will be created in your fork and a new merge request will be started.

    Cherry-pick this commit

    Switch branch
    Cancel
    A new branch will be created in your fork and a new merge request will be started.