Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 159
    • Issues 159
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !196

Closed
Opened Aug 21, 2023 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Fix the 'happiness' bug (Arxiv empty Ngrams)

NOTE: This MR piggybacks on !192 (merged), and it's built on top of the former.

NOTE: It relies on gargantext/crawlers/arxiv-api!2 (merged) being merged.

Fixes #258 (closed).

This commit fixes the issue of the "empty Ngrams". The culprit was a bug in the arxiv-api package, which was fixed by:

gargantext/crawlers/arxiv-api!2 (commits)

In a nutshell, due to the fact the relevant Conduit was never completing, it was blocking the flow function, which was endlessly waiting for the last part of the results to arrive.

Hence we were never calling the flowCorpusUser, which is the function responsible for generating the Ngrams. After realising and fixing the above, we now get the ngrams populated as expected:

Screenshot_2023-08-21_at_11.45.15

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-258-part-2 origin/adinapoli/issue-258-part-2

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/adinapoli/issue-258
git merge --no-ff adinapoli/issue-258-part-2

Step 4. Push the result of the merge to GitLab

git push origin adinapoli/issue-258

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 1
  • Pipelines 1
  • Changes 7
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!196