Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 164
    • Issues 164
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !232

Merged
Opened Dec 12, 2023 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

General Phylo improvements and allow longer strings for `cooc` field

Temporarily fixes #290 (closed).

In particular, I have:

  • Setup a benchmark for the phylo algorithm, to understand and improve its performance;
  • Added a golden test for the phylo algorithm, so that we can tweak the existing algorithm and catch regressions.

In terms of the actual bug that triggered #290 (closed) I haven't done any serious investigation yet because the algorithm takes a long time to compute (at least on my machine, which this morning was busy compiling nix stuff for the upgrade to GHC 9.4.7). My speculation is that due to the fact the phylo spans over a lot of years (from the 1960 to 2024) this is generating a very tall image, which overflows the maximum height supported by graphviz.

Edited Dec 13, 2023 by Alfredo Di Napoli

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-290 origin/adinapoli/issue-290

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-290

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 7
  • Pipelines 3
  • Changes 15
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!232

Revert this commit

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.