Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 158
    • Issues 158
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !366

Merged
Opened 6 months ago by Alfredo Di Napoli@AlfredoDiNapoli4 of 6 tasks completed4/6 tasks
  • Report abuse
Report abuse

Improvements for the "Publish a Corpus" feature

Fixes #425 (closed). General improvements:

  • Fixed a bug in the unpublishing of a node;
  • Added the NodePublishPolicy to the NodeTree data structure, so that the frontend is aware of the type of publishing;
  • BREAKING: rename /unpublish endpoint into /unshare, for better clarity of intentions;
  • Add /node/:node-id/publish endpoint (by specifying the policy);

I have decided to leave outside this MR the following:

  • TODO: Support publishing of notes. This should be tracked by #402 already.
  • TODO: Hide published nodes from private/share view -- need more input from Alexandre.

Companion Frontend MR: purescript-gargantext!484 (merged)

Edited 6 months ago by Alfredo Di Napoli

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-425 origin/adinapoli/issue-425

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-425

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge adinapoli/issue-425 into dev
  • Email patches
  • Plain diff
Pipeline #6983 passed for 0e5860a2 on adinapoli/issue-425

          Merged by delanoe 6 months ago

          The changes were merged into dev with 0e5860a2

          Closed #425 (closed)

          Mentions #402

          • Discussion 5
          • Commits 5
          • Pipelines 5
          • Changes 17
          • Loading...
          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          Ready to merge
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          participants
          Reference: gargantext/haskell-gargantext!366

          Revert this commit

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this commit

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.