Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 159
    • Issues 159
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !374

Closed
Opened Dec 02, 2024 by Grégoire Locqueville@glocqueville
  • Report abuse
Report abuse

Improve the interface to the subcorpus creation feature

Relates to #384

Creating a subcorpus previously returned a Bool to the frontend. Now we give back the ID of the newly created node, and handle errors using a proper error.

Note that I used an InternalValidationError (in Gargantext.API.Node.Corpus.Subcorpus), but I am not sure how the Validation type that goes inside it is supposed to work. I picked the most direct way to turn a String into a Validation, assuming it was the right one, but if someone could have a look and tell me if this is the correct, that would be nice.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 384-let-users-create-a-subcorpus origin/384-let-users-create-a-subcorpus

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff 384-let-users-create-a-subcorpus

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 2
  • Pipelines 4
  • Changes 3
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
New feature
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!374