Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 163
    • Issues 163
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !378

Closed
Opened Dec 30, 2024 by Przemyslaw Kaminski@cgenie
  • Report abuse
Report abuse

Resolve "Uniform ngrams creation"

Related to #224

I am trying to understand better how the ngrams algorithms work.

  1. In analyzing G.D.A.Flow -> reIndex, I simplified things:
    1. We don't need to select whole contexts with hyperdata, it's enough just to select context id with hyperdata
    2. ngramsByDoc was a list, generated from a list of docs. I split that into a pure function being mapped over docs.
    3. I added unit tests in T.Ngrams.Count
    4. I added TermsWeight, this newtype is clearer than Int that we had before
  2. I refactored WithQuery to have only datafield. This is described in #441
Edited Jan 14, 2025 by Przemyslaw Kaminski

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 224-dev-understanding-ngrams origin/224-dev-understanding-ngrams

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff 224-dev-understanding-ngrams

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 20
  • Commits 26
  • Pipelines 23
  • Changes 37
Assignee
Assign to
Epic 0.0.7
Milestone
Epic 0.0.7
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!378