Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 180
    • Issues 180
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !433

Open
Opened Jul 28, 2025 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Allow ngrams to be searched even if they appear deeply nested

One of the bullet points of #498. This MR allows ngram terms nested in a tree to be searched, as before it wasn't the case.

DEMO

nested_ngrams_search

In order to support nested search, we need to be able to recursively search within the children in a tree -- for this reason I have also added support for loop detection inside buildForest. This is good for now, but in practice we shouldn't even pass to buildForest a Map NgramsTerm NgramsElement with cycles.

Edited Aug 04, 2025 by Alfredo Di Napoli

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-498 origin/adinapoli/issue-498

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-498

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 5
  • Commits 3
  • Pipelines 3
  • Changes 5
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
To Review (review requested)
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!433