Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 179
    • Issues 179
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !435

Open
Opened Aug 04, 2025 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Prevent importing ngrams which will lead to loops

Second part of #498.

This MR extends the ngrams machinery such that if we were to try importing ngrams which would lead to loops, GGTX will now reject it:

Screenshot_2025-08-25_at_10.43.19

To the best of my knowledge loops can be created only manually by importing (it shouldn't be possible via the frontend UI to create some), and ngrams extracted from documents are always flattened, this should cover all cases.

@cgenie When you have some spare cycles, would you mind reviewing? I will add the usual inline commentary.

Edited Aug 25, 2025 by Alfredo Di Napoli

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-498-part-2 origin/adinapoli/issue-498-part-2

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-498-part-2

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 9
  • Commits 7
  • Pipelines 6
  • Changes 10
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
To Review (review requested)
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!435