[REFACT] read instances + fix warnings

src/Gargantext/Components/GraphExplorer/API.purs

 module Gargantext.Components.GraphExplorer.API where
 
-import Gargantext.Prelude
-
 import Data.Maybe (Maybe)
-import Effect (Effect)
-import Effect.Aff (Aff, launchAff_)
-
+import Effect.Aff (Aff)
 import Gargantext.Components.GraphExplorer.Types as GET
 import Gargantext.Components.NgramsTable.Core as NTC
 import Gargantext.Hooks.Sigmax.Types as SigmaxT
+import Gargantext.Prelude
 import Gargantext.Routes as GR
 import Gargantext.Sessions (Session, get, post)
 import Gargantext.Types as GT

src/Gargantext/Components/NgramsTable.purs

@@ -23,22 +23,21 @@ import Data.Symbol (SProxy(..))
 import Data.Tuple (Tuple(..), fst, snd)
 import Data.Tuple.Nested ((/\))
 import Effect (Effect)
-import Prelude (class Show, Unit, bind, const, discard, identity, map, mempty, not, pure, show, unit, (#), ($), (&&), (/=), (<$>), (<<<), (<>), (=<<), (==), (||))
-import Reactix as R
-import Reactix.DOM.HTML as H
-import Unsafe.Coerce (unsafeCoerce)
-
 import Gargantext.Components.AutoUpdate (autoUpdateElt)
 import Gargantext.Components.Loader (loader)
 import Gargantext.Components.LoadingSpinner (loadingSpinner)
-import Gargantext.Components.NgramsTable.Core (Action(..), CoreState, Dispatch, NgramsElement(..), NgramsPatch(..), NgramsTable, NgramsTerm, PageParams, PatchMap(..), Versioned(..), VersionedNgramsTable, _NgramsElement, _NgramsTable, _children, _list, _ngrams, _occurrences, _root, addNewNgram, applyNgramsPatches, applyPatchSet, commitPatchR, convOrderBy, filterTermSize, fromNgramsPatches, initialPageParams, loadNgramsTableAll, ngramsTermText, normNgram, patchSetFromMap, replace, rootsOf, singletonNgramsTablePatch, syncPatchesR)
 import Gargantext.Components.NgramsTable.Components as NTC
+import Gargantext.Components.NgramsTable.Core (Action(..), CoreState, Dispatch, NgramsElement(..), NgramsPatch(..), NgramsTable, NgramsTerm, PageParams, PatchMap(..), Versioned(..), VersionedNgramsTable, _NgramsElement, _NgramsTable, _children, _list, _ngrams, _occurrences, _root, addNewNgram, applyNgramsPatches, applyPatchSet, commitPatchR, convOrderBy, filterTermSize, fromNgramsPatches, initialPageParams, loadNgramsTableAll, ngramsTermText, normNgram, patchSetFromMap, replace, rootsOf, singletonNgramsTablePatch, syncPatchesR)
 import Gargantext.Components.Table as T
+import Gargantext.Prelude (class Show, Unit, bind, const, discard, identity, map, mempty, not, pure, show, unit, (#), ($), (&&), (/=), (<$>), (<<<), (<>), (=<<), (==), (||), read)
 import Gargantext.Sessions (Session)
-import Gargantext.Types (CTabNgramType, OrderBy(..), SearchQuery, TabType, TermList(..), TermSize, readTermList, readTermSize, termLists, termSizes)
+import Gargantext.Types (CTabNgramType, OrderBy(..), SearchQuery, TabType, TermList(..), TermSize, termLists, termSizes)
 import Gargantext.Utils (queryMatchesLabel, toggleSet)
 import Gargantext.Utils.List (sortWith) as L
 import Gargantext.Utils.Reactix as R2
+import Reactix as R
+import Reactix.DOM.HTML as H
+import Unsafe.Coerce (unsafeCoerce)
 
 type State' =
   CoreState
@@ -159,7 +158,7 @@ tableContainerCpt { dispatch
                   [ R2.select { id: "picklistmenu"
                               , className: "form-control custom-select"
                               , defaultValue: (maybe "" show termListFilter)
-                              , on: {change: setTermListFilter <<< readTermList <<< R2.unsafeEventValue}}
+                              , on: {change: setTermListFilter <<< read <<< R2.unsafeEventValue}}
                     (map optps1 termLists)]
                 ]
               , H.div {className: "col-md-2", style: {marginTop : "6px"}}
@@ -167,7 +166,7 @@ tableContainerCpt { dispatch
                   [ R2.select {id: "picktermtype"
                               , className: "form-control custom-select"
                               , defaultValue: (maybe "" show termSizeFilter)
-                              , on: {change: setTermSizeFilter <<< readTermSize <<< R2.unsafeEventValue}}
+                              , on: {change: setTermSizeFilter <<< read <<< R2.unsafeEventValue}}
                     (map optps1 termSizes)]
                 ]
               , H.div { className: "col-md-2", style: { marginTop: "6px" } } [

src/Gargantext/Components/NgramsTable/API.purs

 module Gargantext.Components.NgramsTable.API where
 
-import Gargantext.Prelude
-
-import Data.Maybe (Maybe)
-import Effect (Effect)
-import Effect.Aff (Aff, launchAff_)
-
-import Gargantext.Components.NgramsTable.Core as NTC
+import Effect.Aff (Aff)
 import Gargantext.Routes as GR
-import Gargantext.Sessions (Session, get, post)
+import Gargantext.Sessions (Session, post)
 import Gargantext.Types as GT
 
 type UpdateNodeListParams =

src/Gargantext/Components/Nodes/Corpus/Dashboard.purs

 module Gargantext.Components.Nodes.Corpus.Dashboard where
 
+import DOM.Simple.Console (log2)
 import Data.Array as A
 import Data.Maybe (Maybe(..), fromMaybe)
 import Data.Tuple (fst)
 import Data.Tuple.Nested ((/\))
-import DOM.Simple.Console (log2)
 import Effect (Effect)
 import Effect.Aff (launchAff_)
 import Effect.Class (liftEffect)
-import Reactix as R
-import Reactix.DOM.HTML as H
-
-import Gargantext.Prelude
-
-import Gargantext.Components.Node (NodePoly(..))
 import Gargantext.Components.Nodes.Corpus.Chart.Predefined as P
 import Gargantext.Components.Nodes.Dashboard.Types as DT
 import Gargantext.Hooks.Loader (useLoader)
-import Gargantext.Utils.Reactix as R2
+import Gargantext.Prelude
 import Gargantext.Sessions (Session)
 import Gargantext.Types (NodeID)
+import Gargantext.Utils.Reactix as R2
+import Reactix as R
+import Reactix.DOM.HTML as H
 
 type Props =
-  (
-    nodeId :: NodeID
+  ( nodeId :: NodeID
   , session :: Session
   )
 
@@ -49,12 +45,11 @@ dashboardLayoutCpt = R.hooksComponent "G.C.N.C.D.dashboardLayout" cpt
 
       where
         onChange :: NodeID -> R.State Int -> DT.Hyperdata -> Array P.PredefinedChart -> Effect Unit
-        onChange nodeId (_ /\ setReload) (DT.Hyperdata h) charts = do
+        onChange nodeId' (_ /\ setReload) (DT.Hyperdata h) charts = do
           launchAff_ do
-            DT.saveDashboard {
-                hyperdata: DT.Hyperdata $ h { charts = charts }
-              , nodeId
-              , session }
+            DT.saveDashboard { hyperdata: DT.Hyperdata $ h { charts = charts }
+                             , nodeId:nodeId'
+                             , session }
             liftEffect $ setReload $ (+) 1
 
 type LoadedProps =

src/Gargantext/Types.purs

@@ -13,6 +13,7 @@ import Data.Maybe (Maybe(..), maybe)
 import Effect.Aff (Aff)
 import Prim.Row (class Union)
 import URI.Query (Query)
+import Gargantext.Prelude (class Read)
 
 type ID     = Int
 type Name   = String
@@ -43,10 +44,11 @@ instance showTermSize :: Show TermSize where
   show MonoTerm  = "MonoTerm"
   show MultiTerm = "MultiTerm"
 
-readTermSize :: String -> Maybe TermSize
-readTermSize "MonoTerm"  = Just MonoTerm
-readTermSize "MultiTerm" = Just MultiTerm
-readTermSize _           = Nothing
+instance readTermSize :: Read TermSize where
+  read :: String -> Maybe TermSize
+  read "MonoTerm"  = Just MonoTerm
+  read "MultiTerm" = Just MultiTerm
+  read _           = Nothing
 
 termSizes :: Array { desc :: String, mval :: Maybe TermSize }
 termSizes = [ { desc: "All types",        mval: Nothing        }
@@ -92,11 +94,12 @@ termListName GraphTerm = "Map List"
 termListName StopTerm = "Stop List"
 termListName CandidateTerm = "Candidate List"
 
-readTermList :: String -> Maybe TermList
-readTermList "GraphTerm"     = Just GraphTerm
-readTermList "StopTerm"      = Just StopTerm
-readTermList "CandidateTerm" = Just CandidateTerm
-readTermList _               = Nothing
+instance readTermList :: Read TermList where
+  read :: String -> Maybe TermList
+  read "GraphTerm"     = Just GraphTerm
+  read "StopTerm"      = Just StopTerm
+  read "CandidateTerm" = Just CandidateTerm
+  read _               = Nothing
 
 termLists :: Array { desc :: String, mval :: Maybe TermList }
 termLists = [ { desc: "All terms",   mval: Nothing      }