Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
P
purescript-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 138
    • Issues 138
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • purescript-gargantext
  • Issues
  • #358

Closed
Open
Opened Nov 25, 2021 by Przemyslaw Kaminski@cgenie
  • Report abuse
  • New issue
Report abuse New issue

"Add" button in terms shows when table is not empty, but not when term doesn't exist

We have this condition in G.C.NgramsTable:

                       , if A.null props.tableBody && searchQuery /= "" then

This is wrong: suppose we type in a1 into the query and there is only 1 result: data1. The Add "a1" button won't show in this case, even if term doesn't exist in the table, because the tableBody and searchQuery are not empty. This should be somehow refactored, though it could be deep because tableBody is a Array R.Element so it represents rendered HTML already and we don't know what the search results are at this place. Maybe adding a exactMatches :: Boolean would do here?

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
toClose?
Assign labels
  • View project labels
Reference: gargantext/purescript-gargantext#358