Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
P
purescript-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 137
    • Issues 137
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • purescript-gargantext
  • Merge Requests
  • !145

Merged
Opened May 14, 2021 by Przemyslaw Kaminski@cgenie
  • Report abuse
Report abuse

[api] user_id -> userId, parent_id -> parentId in decoding json

Related to #291 (closed)

I changed user_id to userId and parent_id to parentId. I changed all instances and clicked through the website and I don't see any errors. I'm not sure though whether it all should be like this or a mix of user_id/userId, parent_id/parentId.

I'm guessing with graphql we could have this uniform, based on model fetched, with REST it can be different with each endpoint.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 291-dev-dashboard-parent-id-fix origin/291-dev-dashboard-parent-id-fix

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff 291-dev-dashboard-parent-id-fix

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 3
  • Commits 1
  • Changes 3
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
high
Assign labels
  • View project labels
Reference: gargantext/purescript-gargantext!145

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.