Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
P
purescript-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 137
    • Issues 137
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • purescript-gargantext
  • Merge Requests
  • !176

Merged
Opened Aug 24, 2021 by Przemyslaw Kaminski@cgenie
  • Report abuse
Report abuse

Resolve "Errors / Warning feedbacks Backend/FrontEnd"

Related to #80 (closed)

Related to haskell-gargantext#68 (closed)

Error support is added to frontend (mostly this is done for HTTP requests but can be used for other things).

throwError in the long run is a bad practice, I tried to get rid of it anywhere I could.

I also refactored lots of components to just use boxes :: Boxes instead of tasks, errors, etc. This makes for a more unified experience when reading the code.

Edited Aug 24, 2021 by Przemyslaw Kaminski

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 80-dev-frontend-errors origin/80-dev-frontend-errors

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff 80-dev-frontend-errors

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 4
  • Pipelines 15
  • Changes 41
Assignee
Assign to
V4 Release
Milestone
V4 Release
Assign milestone
Time tracking
1
Labels
critical
Assign labels
  • View project labels
Reference: gargantext/purescript-gargantext!176

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.