Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
purescript-gargantext
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Grégoire Locqueville
purescript-gargantext
Commits
1acb85b6
Commit
1acb85b6
authored
6 years ago
by
Alexandre Delanoë
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[DISCUSS] comments to answer to npouillards questions.
parent
2a9c6329
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
Documents.purs
src/Gargantext/Pages/Corpus/Tabs/Documents.purs
+5
-5
No files found.
src/Gargantext/Pages/Corpus/Tabs/Documents.purs
View file @
1acb85b6
...
@@ -147,13 +147,13 @@ layoutDocview = simpleSpec performAction render
...
@@ -147,13 +147,13 @@ layoutDocview = simpleSpec performAction render
performAction Trash {path: nodeId} {documentIdsToDelete} =
performAction Trash {path: nodeId} {documentIdsToDelete} =
void $ lift $ deleteDocuments nodeId (DeleteDocumentQuery {documents: Set.toUnfoldable documentIdsToDelete})
void $ lift $ deleteDocuments nodeId (DeleteDocumentQuery {documents: Set.toUnfoldable documentIdsToDelete})
-- TODO: what to do now that the documents are deleted
-- TODO: what to do now that the documents are deleted
-- * should we reload?
-- * should we reload?
NO (if you change page, yes and come back yes)
-- * should we locally update our data?
-- * should we locally update our data?
YES
-- * should we reset documentIdsToDelete?
-- * should we reset documentIdsToDelete?
YES
-- * if so, how to un-check the checkboxes since the inputs are uncontrolled?
-- * if so, how to un-check the checkboxes since the inputs are uncontrolled?
-- + There is no need to uncheck them if they disapear because we
-- + There is no need to uncheck them if they disapear because we
-- either reload or local update our data.
-- either reload or local update our data.
YES
-- + Sync the checked value using
-- + Sync the checked value using
(why check, just reset documentsIdsToDelete)
-- `checked: Set.member n state.documentIdsToDelete`
-- `checked: Set.member n state.documentIdsToDelete`
render :: Render State Props Action
render :: Render State Props Action
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment