Commit 1acb85b6 authored by Alexandre Delanoë's avatar Alexandre Delanoë

[DISCUSS] comments to answer to npouillards questions.

parent 2a9c6329
...@@ -147,13 +147,13 @@ layoutDocview = simpleSpec performAction render ...@@ -147,13 +147,13 @@ layoutDocview = simpleSpec performAction render
performAction Trash {path: nodeId} {documentIdsToDelete} = performAction Trash {path: nodeId} {documentIdsToDelete} =
void $ lift $ deleteDocuments nodeId (DeleteDocumentQuery {documents: Set.toUnfoldable documentIdsToDelete}) void $ lift $ deleteDocuments nodeId (DeleteDocumentQuery {documents: Set.toUnfoldable documentIdsToDelete})
-- TODO: what to do now that the documents are deleted -- TODO: what to do now that the documents are deleted
-- * should we reload? -- * should we reload? NO (if you change page, yes and come back yes)
-- * should we locally update our data? -- * should we locally update our data? YES
-- * should we reset documentIdsToDelete? -- * should we reset documentIdsToDelete? YES
-- * if so, how to un-check the checkboxes since the inputs are uncontrolled? -- * if so, how to un-check the checkboxes since the inputs are uncontrolled?
-- + There is no need to uncheck them if they disapear because we -- + There is no need to uncheck them if they disapear because we
-- either reload or local update our data. -- either reload or local update our data. YES
-- + Sync the checked value using -- + Sync the checked value using (why check, just reset documentsIdsToDelete)
-- `checked: Set.member n state.documentIdsToDelete` -- `checked: Set.member n state.documentIdsToDelete`
render :: Render State Props Action render :: Render State Props Action
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment