Commit f0fcc16e authored by arturo's avatar arturo

>>> continue

parent f0c2adb1
......@@ -77,8 +77,8 @@ data RawObject
, lbl :: String
, penwidth :: String
, role :: String
-- @WIP: not in API; but present in certain data (eg. "Knowledge
-- visualisation")
-- (?) not in API; but present in certain data (eg. "Knowledge
-- visualisation")
, seaLvl :: Maybe String
, source :: String
, strFrom :: Maybe String
......
......@@ -58,7 +58,6 @@ layoutCpt = here.component "layout" cpt where
sources /\ sourcesBox <-
R2.useBox' (mempty :: Array Source)
-- @WIP: move value to PhyloDataSet?
terms /\ termsBox <-
R2.useBox' (mempty :: Array Term)
......@@ -107,7 +106,8 @@ layoutCpt = here.component "layout" cpt where
o.bb
RS.changeDisplayView displayView
T.write_ true isReadyBox
-- @WIP: handling global variables
-- @XXX: handling global variables
-- (see `Resources.js` how they are being used)
T.write_ (window .. "terms") termsBox
useFirstEffect' do
......@@ -161,8 +161,8 @@ layoutCpt = here.component "layout" cpt where
style <- pure $ (el .. "style")
pure $ (style .= "padding") "initial"
-- @WIP (as some actions are checked by the JS resources via DOMElement
-- UI attribute, for now we create a temporary reference)
-- @XXX: handling global variables
-- (see `Resources.js` how they are being used)
useUpdateEffect1' displayView do
pure $ (window .= "displayView") (show displayView)
......
......@@ -165,8 +165,8 @@ instance Show PubSubEvent where
-----------------------------------------------------------
-- @WIP: "Graphics.D3.Selection" lack of "filter" function
-- @WIP: "Graphics.D3.Selection" lack of "nodes" function
-- @XXX: "Graphics.D3.Selection" lack of "filter" function
-- @XXX: "Graphics.D3.Selection" lack of "nodes" function
selectionFilter :: forall d. String -> D3S.Selection d -> D3Eff (D3S.Selection D3S.Void)
selectionFilter = ffi ["query", "selection", ""] "selection.filter(query)"
......
......@@ -16,7 +16,6 @@ import Reactix as R
import Reactix.DOM.HTML as H
import Toestand as T
-- @WIP: * change "source" default value "" to `Maybe String`
type Props =
( sources :: Array (Source)
, source :: T.Box (String)
......
......@@ -29,7 +29,7 @@ import Gargantext.Components.PhyloExplorer.JSON (PhyloJSONSet(..), RawEdge(..),
import Simple.JSON as JSON
-- @WIP PureScript Date or stick to JavaScript foreign?
-- (?) PureScript Date or stick to JavaScript foreign?
foreign import yearToDate :: String -> Date.Date
foreign import stringToDate :: String -> Date.Date
foreign import utcStringToDate :: String -> Date.Date
......@@ -69,7 +69,7 @@ parsePhyloJSONSet (PhyloJSONSet o) = PhyloDataSet
, links
, name : o.name
, nbBranches : parseInt o.phyloBranches
-- @WIP remotely stringify as a Double instead of an Int (?)
-- (!) remotely stringify as a Double instead of an Int (reason?)
, nbDocs : (parseFloat >>> parseInt') o.phyloDocs
, nbFoundations : parseInt o.phyloFoundations
, nbGroups : parseInt o.phyloGroups
......@@ -157,7 +157,7 @@ parsePeriods epoch
newtype Group = Group
{ bId :: Int
, foundation :: Array Int -- @WIP: Array String ???
, foundation :: Array Int -- (?) Array String ???
, from :: Date.Date
, gId :: Int
, label :: Array String
......@@ -202,7 +202,7 @@ parseGroups epoch
newtype Link = Link
{ from :: Int
, lId :: Int
, label :: String -- @WIP: undefined in Mèmiescape v2, still needed?
, label :: String -- (!) undefined in Mèmiescape v2, still needed?
, to :: Int
}
......@@ -217,8 +217,8 @@ parseLinks
>>> Array.catMaybes
where
-- @WIP: necessary?
-- bc. GroupToGroup as 1-1 relation with "edgeType=link"
-- (?): necessary?
-- bc. GroupToGroup as 1-1 relation with "edgeType=link"
filter :: RawEdge -> Boolean
filter (GroupToGroup o) = o.edgeType == "link"
filter _ = false
......@@ -237,7 +237,7 @@ parseLinks
newtype AncestorLink = AncestorLink
{ from :: Int
, lId :: Int
, label :: String -- @WIP: undefined in Mèmiescape v2, still needed?
, label :: String -- (?) undefined in Mèmiescape v2, still needed?
, to :: Int
}
......@@ -252,8 +252,8 @@ parseAncestorLinks
>>> Array.catMaybes
where
-- @WIP: necessary?
-- bc. GroupToAncestor as 1-1 relation with "edgeType=ancestorLink"
-- (?) necessary?
-- bc. GroupToAncestor as 1-1 relation with "edgeType=ancestorLink"
filter :: RawEdge -> Boolean
filter (GroupToAncestor o) = o.edgeType == "ancestorLink"
filter _ = false
......@@ -285,8 +285,8 @@ parseBranchLinks
>>> Array.catMaybes
where
-- @WIP: necessary?
-- bc. BranchToGroup as 1-1 relation with "edgeType=branchLink"
-- (?) necessary?
-- bc. BranchToGroup as 1-1 relation with "edgeType=branchLink"
filter :: RawEdge -> Boolean
filter (BranchToGroup o) = o.edgeType == "branchLink"
filter _ = false
......@@ -340,9 +340,9 @@ parseSources
>>> String.split (String.Pattern ",")
>>> Array.filter (\s -> not eq 0 $ String.length s)
-- @WIP: as some "Draw.js" business's methods still use `source` as an unsorted
-- `Array String`, we have to dissociate the parsing and sorting
-- computation (hence this second method to use for sorting purposes)
-- (?) `Resources.js` business's methods still use `source` as an unsorted
-- `Array String`, we have to dissociate the parsing and sorting
-- computation (hence this second method to use for sorting purposes)
sortSources :: Array String -> Array Source
sortSources
= Array.mapWithIndex setSource
......@@ -389,7 +389,7 @@ parsePos
Just s -> parseFloat s
-- @WIP: why taking last value? use `any`?
-- (?) why taking last value? use `any`?
getGlobalWeightedValue :: Array Group -> Boolean
getGlobalWeightedValue
= Array.last
......
......@@ -522,7 +522,7 @@ applyTo_ src name args =
infixl 4 applyTo_ as ~~
-- @WIP: DOM.Simple lack of "ClassList" module
-- @XXX: DOM.Simple lack of "ClassList" module
addClass :: forall el. el -> Array String -> Effect Unit
addClass el args = pure $ (el .. "classList") ~~ "add" $ args
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment