1. 20 Feb, 2024 1 commit
  2. 02 Feb, 2024 1 commit
  3. 17 Nov, 2023 1 commit
  4. 16 Nov, 2023 1 commit
  5. 08 Nov, 2023 1 commit
  6. 28 Sep, 2023 2 commits
  7. 08 Sep, 2023 2 commits
    • Przemyslaw Kaminski's avatar
      058fa2fe
    • Przemyslaw Kaminski's avatar
      [ngrams] fixes to ngrams state synchronization · 09b2a0e7
      Przemyslaw Kaminski authored
      The issue was this:
      
      When user clicks around the ngrams table, only local state is
      updated (`ngramsLocalPatch`). After he clicks 'Sychronize', this is
      uploaded to server and `ngramsVersion` number is bumped up. What
      happened is that `ngramsValidPatch` inside internal state was updated
      and so the patch was sychronized locally, without refreshing the
      table. However, this resulted in errors later, when user changed the
      same term, because then, when user changes view to 'Stop terms', the
      table is refreshed with the newly applied terms and `ngramsValidPatch`
      doesn't make sense anymore.
      
      The solution is to set `ngramsValidPatch` to `mempty` and, after state
      is updated, refresh the current table.
      
      It could be argued whether it's the most optimal thing to do and why
      don't we keep things "offline". Well, clicking on 'Sychronize'
      requires the client to be online so why not sync the table already at
      this time?
      
      I guess this makes things bit simpler and I think it renders
      `ngramsValidPatch` unnecessary. So our state could be
      simplified (patches is already a complex beast).
      09b2a0e7
  8. 26 Jun, 2023 1 commit
  9. 21 Jun, 2023 2 commits
  10. 19 Jun, 2023 1 commit
  11. 06 Jun, 2023 2 commits
  12. 05 Jun, 2023 1 commit
  13. 01 Jun, 2023 1 commit
  14. 30 May, 2023 3 commits
  15. 26 May, 2023 1 commit
  16. 24 Apr, 2023 1 commit
  17. 01 Mar, 2023 1 commit
  18. 13 Dec, 2022 2 commits
  19. 15 Nov, 2022 1 commit
  20. 15 Sep, 2022 1 commit
  21. 30 Jun, 2022 2 commits
  22. 21 Jun, 2022 1 commit
  23. 20 Jun, 2022 1 commit