- 22 May, 2025 1 commit
-
-
Przemyslaw Kaminski authored
-
- 21 May, 2025 1 commit
-
-
Grégoire Locqueville authored
-
- 12 May, 2025 3 commits
-
-
Alfredo Di Napoli authored
The refactored DB API now has a separate building block to create an Opaleye query that counts the number of returned results; we do that via `countRows`, exactly like the previous version. However, I have discovered a small footgun in the Opaleye API -- if you have two `Select` statements both calling countRows in a chain, that will always yield a value of 1, because the inner `countRows` will give you the actual number of results by returning a single row with an integer inside (i.e. the count). However, the subsequent (outer) call to `countRows` will return the number of rows of the previous step .. which is always going to be one! The bug was that I had left somewhere the spurious `countRows` in the query which would return the number of documents needed for the TFICF field, triggering the bug (because then we had `it` ALWAYS equal to 1.0). In the new API, while we cannot prevent the bug at the type level we can easily do an audit by grepping for `countRows`, making sure we have exactly one instance, i.e. inside `mkOpaCountQuery`.
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This gigantic commit ports the existing DB operations in GGTX to use the transactional API, meaning that we can now compose DB operations and they will all run in the same Postgres transaction using the same connection, which will eliminate those class of bugs where concurrent DB access might result in an inconsistent state. On top of that, we simplify some parts of the API, for which a summary is given below: 1. The `NodeStoryEnv` management has been greatly simplified; in the new API we don't need an external connection pool to be passed and we don't have to pass IO actions, we can just pass DB operations, therefore we can greatly simplify the API to just pass mostly pure values; 2. Due to the fact that our `DBTx` monad can't do arbitrary IO (which is a good thing) we cannot fire Central Exchange notifications immediately. Rather that happens now is that we collect the `CEMessage` to be sent and we fire them in the relevant concrete monad after we finished with the DB transaction. This means that in principle there would be a small delay between the DB operation taking place and the notification firing but in practice the latency should be negligible and bear in mind this is typically what we want: if we have a long DB Tx that triggers an error in the middle we don't want to be sending out CE messages prematurely if the overall operation didn't succeed! 3. There are still a few places in the codebase where we couldn't make things fully compositional with regards to the DBTx API, because we had Servant handlers which had DB operations mixed with other IO effectful computations (or other things like the notification from the `MonadJobStatus`). For now we are splitting these functions by manually running the partial DB operations, and while this is not ideal it can be fixed in subsequent merge requests. 4. The `WorkerEnv` doesn't use `IOException` as its `MonadError` anymore, as for consistency we can just use `BackendInternalError` by adding a `InternalWorkerError` data constructor accepting the `IOException` triggered by the Worker monad. More testing is needed, with particular attention to performance (regression) but this should hopefully offer a decent baseline.
-
- 28 Apr, 2025 4 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
.. before we start adding the transactional tests (and testing the rollback).
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
- 07 Apr, 2025 3 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This commit introduces/improves the `parseTvsWithDiagnostics` function to parse the input TSV incrementally, collecting errors as we go, and eventually reporting them upstream via the newly added `emitTsvParseWarning` function.
-
Alfredo Di Napoli authored
-
- 27 Mar, 2025 2 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
- 26 Mar, 2025 4 commits
-
-
Alfredo Di Napoli authored
Concurrency is a good way to trigger any interleaving bug.
-
Alfredo Di Napoli authored
They can be enabled with `GGTX_LOG_LEVEL` during tests.
-
Alfredo Di Napoli authored
The bug is elsewhere.
-
Alfredo Di Napoli authored
This commit extends the timeout around the `readTChan` in the ping-pong test to 60 seconds, mostly to account for CI slowness and to rule-out potential source of flakyness. The calls to `threadDelay` have been removed, as they doesn't seem to affect the overall stability of the test (at least locally) -- the point of the exercise is trying to expose as much as possible potential problems which might be masked by active waits.
-
- 25 Mar, 2025 5 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
Before we were repeating the same code to initialise all the different loggers. This commit introduces two stock loggers called `ioStdLogger` and `monadicStdLogger` which can be reused many times. It also allows the `GGTX_LOG_LEVEL` to take effect during `readConfig`, so that the `startupInfo` would show up the correct information.
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
- 20 Mar, 2025 1 commit
-
-
Alfredo Di Napoli authored
This commit fixes a bug where a user member of a team (but NOT the owner of such team) couldn't move nodes.
-
- 18 Mar, 2025 1 commit
-
-
Alfredo Di Napoli authored
-
- 17 Mar, 2025 1 commit
-
-
Alfredo Di Napoli authored
-
- 12 Mar, 2025 1 commit
-
-
Przemyslaw Kaminski authored
-
- 10 Mar, 2025 3 commits
-
-
Alfredo Di Napoli authored
The problem was caused by the improper usage of `delegate_ctrl` when creating the coreNLP process. For a long time I was under the impression this flag was essential to allow child processes to shutdown cleanly without leaving zombie threads, but the result here in the context of the testsuite was that the coreNLP server was receiving the first Ctrl^C, completely starving the Haskell RTS, which wouldn't receive any and as a result our testsuite would be running forever.
-
Alfredo Di Napoli authored
This commit correctly propagates the correct `LogConfig` in all the places where we were just defaulting to log everything, and this allows us to silence debug logs in tests, unless we want them.
-
Alfredo Di Napoli authored
This will allow us to find all the use site of this function, trying to see if we can use only `withLogger` or correctly control the logging verbosity via the `HasLogger` and `LogInitParams`.
-
- 06 Mar, 2025 1 commit
-
-
Przemyslaw Kaminski authored
-
- 03 Mar, 2025 1 commit
-
-
Alfredo Di Napoli authored
-
- 28 Feb, 2025 3 commits
-
-
Przemyslaw Kaminski authored
All calls were basically: nlpServer <- view (nlpServerGet lang) addDocumentsToHyperCorpus nlpServer ...
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
- 27 Feb, 2025 5 commits
-
-
Przemyslaw Kaminski authored
-
Przemyslaw Kaminski authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
We are now around 6/7 times slower than the LLVM code.
-