Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
haskell-gargantext
haskell-gargantext
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 159
    • Issues 159
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gargantext
  • haskell-gargantexthaskell-gargantext
  • Merge Requests
  • !402

Merged
Opened Apr 07, 2025 by Alfredo Di Napoli@AlfredoDiNapoli
  • Report abuse
Report abuse

Proper incremental TSV parser

Addresses #380.

This MR introduces a new function called parseTsvWithDiagnostics which is used to implement the parseTsvC function, used for importing new documents in Gargantext.

The parseTsvWithDiagnostics is an incremental function using cassava's incremental parser API, which allows us to incrementally parse each and every row of a document, collecting any error as we go.

I have used the original .tsv data from ticket #380 and now it parses as it should, discarding the last problematic row.

I have also added a new emitWarning function to the MonadJobStatus API, which we now use to emit all such warnings.

I suspect that we will need to modify the frontend to handle them; I will open a separate ticket for that.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b adinapoli/issue-380 origin/adinapoli/issue-380

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/dev
git merge --no-ff adinapoli/issue-380

Step 4. Push the result of the merge to GitLab

git push origin dev

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 12
  • Commits 8
  • Pipelines 6
  • Changes 20
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
To Review (review requested)
Assign labels
  • View project labels
Reference: gargantext/haskell-gargantext!402

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.