- 12 May, 2025 1 commit
-
-
Alfredo Di Napoli authored
This gigantic commit ports the existing DB operations in GGTX to use the transactional API, meaning that we can now compose DB operations and they will all run in the same Postgres transaction using the same connection, which will eliminate those class of bugs where concurrent DB access might result in an inconsistent state. On top of that, we simplify some parts of the API, for which a summary is given below: 1. The `NodeStoryEnv` management has been greatly simplified; in the new API we don't need an external connection pool to be passed and we don't have to pass IO actions, we can just pass DB operations, therefore we can greatly simplify the API to just pass mostly pure values; 2. Due to the fact that our `DBTx` monad can't do arbitrary IO (which is a good thing) we cannot fire Central Exchange notifications immediately. Rather that happens now is that we collect the `CEMessage` to be sent and we fire them in the relevant concrete monad after we finished with the DB transaction. This means that in principle there would be a small delay between the DB operation taking place and the notification firing but in practice the latency should be negligible and bear in mind this is typically what we want: if we have a long DB Tx that triggers an error in the middle we don't want to be sending out CE messages prematurely if the overall operation didn't succeed! 3. There are still a few places in the codebase where we couldn't make things fully compositional with regards to the DBTx API, because we had Servant handlers which had DB operations mixed with other IO effectful computations (or other things like the notification from the `MonadJobStatus`). For now we are splitting these functions by manually running the partial DB operations, and while this is not ideal it can be fixed in subsequent merge requests. 4. The `WorkerEnv` doesn't use `IOException` as its `MonadError` anymore, as for consistency we can just use `BackendInternalError` by adding a `InternalWorkerError` data constructor accepting the `IOException` triggered by the Worker monad. More testing is needed, with particular attention to performance (regression) but this should hopefully offer a decent baseline.
-
- 30 Jan, 2025 1 commit
-
-
Przemyslaw Kaminski authored
commit be879b1e Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Thu Jan 30 18:22:44 2025 +0100 [ngrams] code fixes according to review Related MR: !378 commit bf89561b Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Wed Jan 22 21:11:47 2025 +0100 [test] notification on node move Also, some small refactorings. commit 3d5d74ab Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Wed Jan 22 20:13:44 2025 +0100 [tests] add notifications func comment, fix core/notifications indent commit b8ea3af2 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Wed Jan 22 19:13:35 2025 +0100 [update-project-dependencies] commit 1217baf4 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Wed Jan 22 19:09:17 2025 +0100 [tests] notifications: test async notifications for update tree Related to #418 commit 874785e9 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 21 06:06:27 2025 +0100 [refactor] unify Database & ExternalIDs These types are the same, except for Database.Empty I managed to have backwards compatibility with the frontend format, hence the frontend doesn't need any changes. commit e7b16520 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 21 06:05:57 2025 +0100 [cabal] upgrade haskell-bee to fix TSRetry and ESRepeat issues commit ad045ae0 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Jan 20 06:32:49 2025 +0100 [cabal] upgrade haskell-bee tag commit b3910bb4 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 14 10:56:12 2025 +0100 [test] move some Arbitrary instances to Test/Instances.hs commit bb282d02 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 14 09:17:23 2025 +0100 [test] WithQuery offline test (with EPO constructor) commit c0fe2e51 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 14 06:59:45 2025 +0100 [query] move EPO user/token into the datafield This simplifies the WithQuery structure even more commit 93586adc Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Jan 13 17:45:42 2025 +0100 [tests] fix WithQuery frontend serialization test Also, add WithQuery pubmed test (with api_key) commit bc29319c Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Jan 13 10:13:15 2025 +0100 [ngrams] simplify WithQuery json structure There is now only a 'datafield' field, no need for duplicated 'database'. Related to #441 commit e6fdbee4 Merge: 95dc32b3 13457ca8 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Fri Jan 10 12:03:59 2025 +0100 Merge branch 'dev' into 224-dev-understanding-ngrams commit 95dc32b3 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 7 20:01:11 2025 +0100 [ngrams] refactor PubMed DB type (to include Maybe APIKey) commit baa2491f Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 7 18:09:04 2025 +0100 [refactor] searx search refactoring commit fcf83bf7 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Tue Jan 7 11:14:03 2025 +0100 [ngrams] more types annotations commit 0d8a77c4 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 16:15:07 2024 +0100 [ngrams, test] refactor: Count -> Terms commit 85f1dffe Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 14:35:05 2024 +0100 [ngrams] refactor opaque Int into TermsWeight newtype commit a81ea049 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 14:34:39 2024 +0100 [CLI] fix limit removal It wasn't used anyways. commit d1dfbf79 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 11:35:41 2024 +0100 [ngrams] one more simplification in ngramsByDoc' commit fcb48b8f Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 11:33:33 2024 +0100 [ngrams] some more simplification of ngramsByDoc' commit ab7c1766 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 30 11:00:19 2024 +0100 [ngrams, tests] understanding ngramsByDoc better commit 35c2d0b0 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 23 21:20:29 2024 +0100 [ngrams] small simplification to docNgrams function commit 161ac077 Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Mon Dec 23 18:35:59 2024 +0100 [ngrams] annotate types of ngrams algorithms commit 08c7c91c Author: Przemysław Kaminski <pk@intrepidus.pl> Date: Sat Dec 21 09:45:00 2024 +0100 [ngrams] improve function documentation, add types, add unit tests I want to understand ngrams algorithms better.
-
- 07 Jan, 2025 1 commit
-
-
Przemyslaw Kaminski authored
-
- 30 Dec, 2024 1 commit
-
-
Przemyslaw Kaminski authored
-
- 09 Apr, 2024 1 commit
-
-
Przemyslaw Kaminski authored
-
- 03 Apr, 2024 1 commit
-
-
Przemyslaw Kaminski authored
-
- 27 Mar, 2024 1 commit
-
-
Przemyslaw Kaminski authored
It's better to enumerate fields than not - easier to search later. Also, a performance improvement for queryNgramsOccurrences (no VALUES).
-
- 22 Mar, 2024 1 commit
-
-
Przemyslaw Kaminski authored
We had CoreNLP hardcoded, however with Spacy this resulted in selectLems returning no entries, because the algo_id from DB didn't match. Hence no singulars grouping.
-
- 21 Mar, 2024 1 commit
-
-
Przemyslaw Kaminski authored
This contains only data, removes some Database dependency in imports.
-
- 20 Mar, 2024 1 commit
-
-
Przemyslaw Kaminski authored
-
- 11 Mar, 2024 1 commit
-
-
Alfredo Di Napoli authored
This commit refactors ever so slightly the '.Stem' modules to create a unified interface; now Gargantext.Core.Text.Terms.Mono.Stem exports a single 'stem' function which can be used with different `StemmingAlgorithm`s, and now the other algorithms' functions have been shielded behind internal modules. This makes possible to see at glance which part of Garg are using which stemming algorithm, as it wasn't always clearer before. This also allows us to have a better control over the langugages, as not all the stemming algorithms supports all the languages that Garg supports.
-
- 04 Dec, 2023 2 commits
-
-
Alfredo Di Napoli authored
-
Alfredo Di Napoli authored
This commit adds a `panicTrace` function to be used as a drop-in replacement of the `panic` function, with the difference that we wrap the error in a `WithStacktrace` error, to be later caught and logged.
-
- 12 Oct, 2023 1 commit
-
-
Przemyslaw Kaminski authored
Basically, Gargantext.Prelude exports all of Protolude now.
-
- 04 Sep, 2023 1 commit
-
-
Alfredo Di Napoli authored
This commit refactors the codebase to add a new function called `addDocumentsToHyperCorpus` which generalises the common pattern of calling `insertMasterDocs` and later adding the documents via the DB `Doc` functions. It also "lowers" some functions to run into a plain `DBCmd`.
-
- 23 Mar, 2023 1 commit
-
-
Przemyslaw Kaminski authored
-
- 16 Mar, 2023 1 commit
-
-
Przemyslaw Kaminski authored
-
- 25 Jan, 2023 1 commit
-
-
Przemyslaw Kaminski authored
Based on the suggestions in https://kodimensional.dev/space-leak
-
- 07 Nov, 2022 1 commit
-
-
Przemyslaw Kaminski authored
-
- 27 Oct, 2022 1 commit
-
-
Przemyslaw Kaminski authored
-
- 13 Sep, 2021 1 commit
-
-
Przemyslaw Kaminski authored
-
- 28 Jul, 2021 1 commit
-
-
Przemyslaw Kaminski authored
-
- 29 Apr, 2021 1 commit
-
-
Alexandre Delanoë authored
-
- 19 Jan, 2021 2 commits
-
-
Alexandre Delanoë authored
-
Alexandre Delanoë authored
-
- 18 Jan, 2021 1 commit
-
-
Alexandre Delanoë authored
-
- 15 Jan, 2021 1 commit
-
-
Alexandre Delanoë authored
-
- 08 Jan, 2021 3 commits
-
-
Alexandre Delanoë authored
-
Alexandre Delanoë authored
-
Alexandre Delanoë authored
-
- 07 Jan, 2021 2 commits
-
-
Alexandre Delanoë authored
-
Alexandre Delanoë authored
-
- 06 Jan, 2021 1 commit
-
-
Alexandre Delanoë authored
-
- 22 Dec, 2020 1 commit
-
-
Alexandre Delanoë authored
-
- 08 Oct, 2020 1 commit
-
-
Nicolas Pouillard authored
-
- 01 Oct, 2020 1 commit
-
-
Przemyslaw Kaminski authored
-
- 17 Sep, 2020 1 commit
-
-
Alexandre Delanoë authored
-
- 08 Sep, 2020 1 commit
-
-
Alexandre Delanoë authored
-
- 26 Aug, 2020 1 commit
-
-
Alexandre Delanoë authored
-
- 01 Jul, 2020 1 commit
-
-
Alexandre Delanoë authored
-